Commit 18143f24 authored by Fabian Meyer's avatar Fabian Meyer
Browse files

Make BarzilaiBorwein return absolute constant step

parent 2eb2ffbf

include/gdcpp.h

+2 −2
Original line number Original line Diff line number Diff line
@@ -326,7 +326,7 @@ namespace gdc 
        }

        }

    public:

    public:

        BarzilaiBorwein()

        BarzilaiBorwein()

            : BarzilaiBorwein(Method::Direct, 1e-2)

            : BarzilaiBorwein(Method::Direct, 1e-4)

        { }

        { }





        BarzilaiBorwein(const Method method, const Scalar constStep)

        BarzilaiBorwein(const Method method, const Scalar constStep)
@@ -357,7 +357,7 @@ namespace gdc 
            Scalar stepSize = 0;

            Scalar stepSize = 0;

            if(lastXval_.size() == 0)

            if(lastXval_.size() == 0)

            {

            {

                stepSize = (1 / gradient.norm()) * constStep_;

                stepSize = constStep_;

            }

            }

            else

            else

            {

            {