From 52ee50b2e9b81fc21364b8e70a5d04bc2ed42227 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakub=20Klinkovsk=C3=BD?= <klinkovsky@mmg.fjfi.cvut.cz>
Date: Sat, 25 Sep 2021 07:55:42 +0200
Subject: [PATCH] Added FIXME notes for the getSerializationType methods in
segments
---
src/TNL/Algorithms/Segments/BiEllpack.hpp | 1 +
src/TNL/Algorithms/Segments/BiEllpackView.hpp | 1 +
src/TNL/Algorithms/Segments/CSR.hpp | 1 +
src/TNL/Algorithms/Segments/CSRView.hpp | 3 ++-
src/TNL/Algorithms/Segments/ChunkedEllpack.hpp | 1 +
src/TNL/Algorithms/Segments/ChunkedEllpackView.hpp | 1 +
src/TNL/Algorithms/Segments/Ellpack.hpp | 1 +
src/TNL/Algorithms/Segments/EllpackView.hpp | 1 +
src/TNL/Algorithms/Segments/SlicedEllpack.hpp | 1 +
src/TNL/Algorithms/Segments/SlicedEllpackView.hpp | 1 +
10 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/TNL/Algorithms/Segments/BiEllpack.hpp b/src/TNL/Algorithms/Segments/BiEllpack.hpp
index 4bbccbb0ee..ddb3c03424 100644
--- a/src/TNL/Algorithms/Segments/BiEllpack.hpp
+++ b/src/TNL/Algorithms/Segments/BiEllpack.hpp
@@ -84,6 +84,7 @@ String
BiEllpack< Device, Index, IndexAllocator, Organization, WarpSize >::
getSerializationType()
{
+ // FIXME: the serialized data DEPEND on the Organization and WarpSize parameters, so it should be reflected in the serialization type
return "BiEllpack< [any_device], " + TNL::getSerializationType< IndexType >() + " >";
}
diff --git a/src/TNL/Algorithms/Segments/BiEllpackView.hpp b/src/TNL/Algorithms/Segments/BiEllpackView.hpp
index ab79d58333..8a1b035aa1 100644
--- a/src/TNL/Algorithms/Segments/BiEllpackView.hpp
+++ b/src/TNL/Algorithms/Segments/BiEllpackView.hpp
@@ -97,6 +97,7 @@ String
BiEllpackView< Device, Index, Organization, WarpSize >::
getSerializationType()
{
+ // FIXME: the serialized data DEPEND on the Organization and WarpSize parameters, so it should be reflected in the serialization type
return "BiEllpack< [any_device], " + TNL::getSerializationType< IndexType >() + " >";
}
diff --git a/src/TNL/Algorithms/Segments/CSR.hpp b/src/TNL/Algorithms/Segments/CSR.hpp
index 0d15790bf8..0bd2d33ca6 100644
--- a/src/TNL/Algorithms/Segments/CSR.hpp
+++ b/src/TNL/Algorithms/Segments/CSR.hpp
@@ -80,6 +80,7 @@ getSerializationType()
{
return "CSR< [any_device], " +
TNL::getSerializationType< IndexType >() + ", " +
+ // FIXME: the serialized data do not depend on the the kernel type so it should not be in the serialization type
TNL::getSerializationType< KernelType >() + " >";
}
diff --git a/src/TNL/Algorithms/Segments/CSRView.hpp b/src/TNL/Algorithms/Segments/CSRView.hpp
index 4343e672bc..7aac457afa 100644
--- a/src/TNL/Algorithms/Segments/CSRView.hpp
+++ b/src/TNL/Algorithms/Segments/CSRView.hpp
@@ -80,7 +80,8 @@ CSRView< Device, Index, Kernel >::
getSerializationType()
{
return "CSR< [any_device], " +
- TNL::getSerializationType< IndexType >() +
+ TNL::getSerializationType< IndexType >() + ", " +
+ // FIXME: the serialized data do not depend on the the kernel type so it should not be in the serialization type
TNL::getSerializationType< KernelType >() + " >";
}
diff --git a/src/TNL/Algorithms/Segments/ChunkedEllpack.hpp b/src/TNL/Algorithms/Segments/ChunkedEllpack.hpp
index e39a166707..9a08957da1 100644
--- a/src/TNL/Algorithms/Segments/ChunkedEllpack.hpp
+++ b/src/TNL/Algorithms/Segments/ChunkedEllpack.hpp
@@ -88,6 +88,7 @@ String
ChunkedEllpack< Device, Index, IndexAllocator, Organization >::
getSerializationType()
{
+ // FIXME: the serialized data DEPEND on the Organization parameter, so it should be reflected in the serialization type
return "ChunkedEllpack< [any_device], " + TNL::getSerializationType< IndexType >() + " >";
}
diff --git a/src/TNL/Algorithms/Segments/ChunkedEllpackView.hpp b/src/TNL/Algorithms/Segments/ChunkedEllpackView.hpp
index 6fc7671079..a48afead54 100644
--- a/src/TNL/Algorithms/Segments/ChunkedEllpackView.hpp
+++ b/src/TNL/Algorithms/Segments/ChunkedEllpackView.hpp
@@ -122,6 +122,7 @@ String
ChunkedEllpackView< Device, Index, Organization >::
getSerializationType()
{
+ // FIXME: the serialized data DEPEND on the Organization parameter, so it should be reflected in the serialization type
return "ChunkedEllpack< [any_device], " + TNL::getSerializationType< IndexType >() + " >";
}
diff --git a/src/TNL/Algorithms/Segments/Ellpack.hpp b/src/TNL/Algorithms/Segments/Ellpack.hpp
index 27e7dcbe3c..baef4d1613 100644
--- a/src/TNL/Algorithms/Segments/Ellpack.hpp
+++ b/src/TNL/Algorithms/Segments/Ellpack.hpp
@@ -99,6 +99,7 @@ String
Ellpack< Device, Index, IndexAllocator, Organization, Alignment >::
getSerializationType()
{
+ // FIXME: the serialized data DEPEND on the Organization and Alignment parameters, so it should be reflected in the serialization type
return "Ellpack< [any_device], " + TNL::getSerializationType< IndexType >() + " >";
}
diff --git a/src/TNL/Algorithms/Segments/EllpackView.hpp b/src/TNL/Algorithms/Segments/EllpackView.hpp
index 6f49c55eef..e283a75d0e 100644
--- a/src/TNL/Algorithms/Segments/EllpackView.hpp
+++ b/src/TNL/Algorithms/Segments/EllpackView.hpp
@@ -205,6 +205,7 @@ String
EllpackView< Device, Index, Organization, Alignment >::
getSerializationType()
{
+ // FIXME: the serialized data DEPEND on the Organization and Alignment parameters, so it should be reflected in the serialization type
return "Ellpack< [any_device], " + TNL::getSerializationType< IndexType >() + " >";
}
diff --git a/src/TNL/Algorithms/Segments/SlicedEllpack.hpp b/src/TNL/Algorithms/Segments/SlicedEllpack.hpp
index 8a4903cbd6..652eceb566 100644
--- a/src/TNL/Algorithms/Segments/SlicedEllpack.hpp
+++ b/src/TNL/Algorithms/Segments/SlicedEllpack.hpp
@@ -93,6 +93,7 @@ String
SlicedEllpack< Device, Index, IndexAllocator, Organization, SliceSize >::
getSerializationType()
{
+ // FIXME: the serialized data DEPEND on the Organization and Alignment parameters, so it should be reflected in the serialization type
return "SlicedEllpack< [any_device], " + TNL::getSerializationType< IndexType >() + " >";
}
diff --git a/src/TNL/Algorithms/Segments/SlicedEllpackView.hpp b/src/TNL/Algorithms/Segments/SlicedEllpackView.hpp
index 5b97c72e20..d7ef9524c8 100644
--- a/src/TNL/Algorithms/Segments/SlicedEllpackView.hpp
+++ b/src/TNL/Algorithms/Segments/SlicedEllpackView.hpp
@@ -83,6 +83,7 @@ String
SlicedEllpackView< Device, Index, Organization, SliceSize >::
getSerializationType()
{
+ // FIXME: the serialized data DEPEND on the Organization and Alignment parameters, so it should be reflected in the serialization type
return "SlicedEllpack< [any_device], " + TNL::getSerializationType< IndexType >() + " >";
}
--
GitLab