Grids todo list
Continuing #52 (closed)...
-
use .vti
files for the storage of grids, dropTNLReader
-
getEntityIndex()
should be removed from grid - users should callentity.getIndex()
-
getEntity()
andgetEntitiesCount()
should haveint Dimension
template parameter -
isBoundaryEntity()
should be moved fromGridEntity
toGrid
- it is not only an entity attribute, it is always bound to the particular mesh. Generally, entities might be shared between multiple submeshes, so the method does not make sense in the general interface. There might also be read-only views for partitions of the mesh (see vienna-grid). [ ] thegetMesh()
method should be removed fromGridEntity
- for the same reason asisBoundaryEntity()
(it is also an optimization because the size of the entity structure will be smaller)-
getCenter()
andgetMeasure()
should be plain functions taking aMesh
andMeshEntity
as parameters. This is because general MeshEntity stores only indices of the subvertices, the points have to be accessed via Mesh class. See also Effective C++ Item 23 Prefer non-member non-friend functions to member functions and the Open-closed principle.