Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • tnl-dev tnl-dev
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 37
    • Issues 37
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • TNLTNL
  • tnl-devtnl-dev
  • Issues
  • #89
Closed
Open
Issue created Jul 14, 2021 by Tomáš Oberhuber@oberhuberMaintainer

Sorting TODO

TODO for Quicksort:

  • refactoring the code of implementation
    • there is a fixed type int instead of Index
    • I have splitted the code between Quicksort and Quicksorter because Quicksorter cannot have static metod sort - Value and Device must be types of the class not the method sort. If we can refactor Quicksorter so that it is easier to use, we can merge Quicksort and Quicksorter togther.
    • TNL/Algorithms/Sorting/details contains several files with helper functions and kernels for Quicksort like quicksort_kernel.h, quicksort_1Block.h, reduction.h etc. We should check them for duplicities and rename them or merge them.
  • implementation for devices Sequential () and Host ( or even Rocm )

TODO for bitonic sort:

  • refactoring
  • port for Rocm

General TODO:

  • we do not have inplace sort that could be used with lambda functions for Host
  • refactoring and extension of unit tests
  • fetch CUDA samples from git repo - https://github.com/NVIDIA/cuda-samples - instead of relying on local installation
Edited Jul 19, 2021 by Tomáš Oberhuber
Assignee
Assign to
Time tracking