Commit 4893aad8 authored by Jakub Klinkovský's avatar Jakub Klinkovský
Browse files

Added assertions to MpiCommunicator.h checking that MPI functions are not... 

Added assertions to MpiCommunicator.h checking that MPI functions are not called with the null group
parent 767321a7

src/TNL/Communicators/MpiCommunicator.h

+19 −10
Original line number Diff line number Diff line
@@ -207,6 +207,7 @@ class MpiCommunicator 
      {

#ifdef HAVE_MPI

        TNL_ASSERT_TRUE(IsInitialized(), "Fatal Error - MPI communicator is not initialized");

        TNL_ASSERT_NE(group, NullGroup, "GetRank cannot be called with NullGroup");

        int rank;

        MPI_Comm_rank(group,&rank);

        return rank;
@@ -219,6 +220,7 @@ class MpiCommunicator 
      {

#ifdef HAVE_MPI

         TNL_ASSERT_TRUE(IsInitialized(), "Fatal Error - MPI communicator is not initialized");

         TNL_ASSERT_NE(group, NullGroup, "GetSize cannot be called with NullGroup");

         int size;

         MPI_Comm_size(group,&size);

         return size;
@@ -251,11 +253,12 @@ class MpiCommunicator 
#endif

        }



         static void Barrier(CommunicationGroup comm)

         static void Barrier(CommunicationGroup group)

         {

#ifdef HAVE_MPI

            TNL_ASSERT_TRUE(IsInitialized(), "Fatal Error - MPI communicator is not initialized");

            MPI_Barrier(comm);

            TNL_ASSERT_NE(group, NullGroup, "Barrier cannot be called with NullGroup");

            MPI_Barrier(group);

#else

            throw Exceptions::MPISupportMissing();

#endif
@@ -266,6 +269,7 @@ class MpiCommunicator 
         {

#ifdef HAVE_MPI

            TNL_ASSERT_TRUE(IsInitialized(), "Fatal Error - MPI communicator is not initialized");

            TNL_ASSERT_NE(group, NullGroup, "ISend cannot be called with NullGroup");

            Request req;

            MPI_Isend((void*) data, count, MPIDataType(data) , dest, 0, group, &req);

            return req;
@@ -279,6 +283,7 @@ class MpiCommunicator 
         {

#ifdef HAVE_MPI

            TNL_ASSERT_TRUE(IsInitialized(), "Fatal Error - MPI communicator is not initialized");

            TNL_ASSERT_NE(group, NullGroup, "IRecv cannot be called with NullGroup");

            Request req;

            MPI_Irecv((void*) data, count, MPIDataType(data) , src, 0, group, &req);

            return req;
@@ -302,6 +307,7 @@ class MpiCommunicator 
        {

#ifdef HAVE_MPI

           TNL_ASSERT_TRUE(IsInitialized(), "Fatal Error - MPI communicator is not initialized");

           TNL_ASSERT_NE(group, NullGroup, "BCast cannot be called with NullGroup");

           MPI_Bcast((void*) &data, count,  MPIDataType(data), root, group);

#else

           throw Exceptions::MPISupportMissing();
@@ -316,6 +322,7 @@ class MpiCommunicator 
                               CommunicationGroup group)

        {

#ifdef HAVE_MPI

            TNL_ASSERT_NE(group, NullGroup, "Allreduce cannot be called with NullGroup");

            MPI_Allreduce( (const void*) data, (void*) reduced_data,count,MPIDataType(data),op,group);

#else

            throw Exceptions::MPISupportMissing();
@@ -332,6 +339,7 @@ class MpiCommunicator 
                    CommunicationGroup group)

         {

#ifdef HAVE_MPI

            TNL_ASSERT_NE(group, NullGroup, "Reduce cannot be called with NullGroup");

            MPI_Reduce( (void*) data, (void*) reduced_data,count,MPIDataType(data),op,root,group);

#else

            throw Exceptions::MPISupportMissing();
@@ -350,6 +358,7 @@ class MpiCommunicator 
                                  CommunicationGroup group )

         {

#ifdef HAVE_MPI

            TNL_ASSERT_NE(group, NullGroup, "SendReceive cannot be called with NullGroup");

            MPI_Status status;

            MPI_Sendrecv( ( void* ) sendData,

                          sendCount,