Commit cdb171fe authored by Lukas Cejka's avatar Lukas Cejka Committed by Tomáš Oberhuber
Browse files

Removed commented personal TODO.

parent c88935b8
Loading
Loading
Loading
Loading
+0 −64
Original line number Diff line number Diff line
@@ -8,70 +8,6 @@

/* See Copyright Notice in tnl/Copyright */

// TODO
/*
  * getType()                           ::HOW?  How to test this for each format? edit string how?
 *      MISTAKE! found it for Cuda instead of Devices::Cuda. Incorrect String in src/TNL/Devices/Cuda.cpp
 * getTypeVirtual()                     ::TEST? This just calls getType().
 * getSerializationType()               ::TEST? This just calls getType().
 * getSerializationTypeVirtual()        ::TEST? This just calls getSerializationType().
 * setDimensions()                          ::DONE
 * setLike()                                ::DONE
 * setCompressedRowLengths()            ::NOT IMPLEMENTED! The function body is empty.
 * getRowLength()                           ::DONE
 * getRowLengthFast()                   ::TEST? How to test __cuda_callable__? ONLY TEST ON CPU FOR NOW
 * getMaxRowLength()                    ::TEST? This function is identical to getRowLength().
 * getNumberOfMatrixElements()              ::DONE
 * getNumberOfNonZeroMatrixElements()       ::DONE
 * reset()                                  ::DONE
 * setValue()                               ::DONE
 * operator()                           ::TEST? How to test __cuda_callable__? ONLY TEST ON CPU FOR NOW
 * const operator()                     ::TEST? How to test __cuda_callable__? ONLY TEST ON CPU FOR NOW
 * setElementFast()                     ::TEST? How to test __cuda_callable__? ONLY TEST ON CPU FOR NOW
 * setElement()                             ::DONE ; USED! in any test with individual value assignment.
 * addElementFast()                     ::TEST? How to test __cuda_callable__? ONLY TEST ON CPU FOR NOW
 * addElement()                             ::DONE
 * setRowFast()                         ::TEST? How to test __cuda_callable__? ONLY TEST ON CPU FOR NOW
 * setRow()                                 ::DONE
 *      MISTAKE! This function unlike the setRow() for CSR, doesn't replace all the elements of a row, it only replaces the elements it has values for in its arrays.
 * addRowFast()                         ::TEST? How to test __cuda_callable__? ONLY TEST ON CPU FOR NOW
 * addRow()                                 ::DONE
 * getElementFast()                     ::TEST? How to test __cuda_callable__? ONLY TEST ON CPU FOR NOW
 * getElement()                             ::USED! in any test with individual value reading.
 * getRowFast()                         ::TEST? How to test __cuda_callable__? ONLY TEST ON CPU FOR NOW
 * getRow()                             ::TEST? How to test __cuda_callable__? ONLY TEST ON CPU FOR NOW
 * const getRow()                       ::TEST? How to test __cuda_callable__? ONLY TEST ON CPU FOR NOW
 * MatrixRow getRow()                   ::TEST? How to test __cuda_callable__? ONLY TEST ON CPU FOR NOW
 * ConstMatrixRow getRow()              ::TEST? How to test __cuda_callable__? ONLY TEST ON CPU FOR NOW
 * rowVectorProduct()                   ::TEST? How to test __cuda_callable__? ONLY TEST ON CPU FOR NOW
 * vectorProduct()                          ::DONE
 *      This used to throw illegal memory access, but instead of using ints for vectors, using Types, helped.
 * addMatrix()                              ::DONE
 * DenseMatrixProductKernel()           ::HOW? How to test __global__?
 * getMatrixProdut()                    ::HOW? It won't build: When testing CPU: no parameters match function DenseMatrixProductKernel(); when testing GPU: identifier tnlCudaMin is undefined. 
 * DenseTranspositionAlignedKernel()    ::HOW? How to test __global__?
 * DenseTranspositionNonAlignedKernel() ::HOW? How to test __global__?
 * getTransposition()                   ::HOW? It won't build when testing CPU: no parameters match functions DenseTranspositionAlignedKernel() and DenseTranspositionNonAlignedKernel(). On GPU if will throw terminate and (core dumped).
 *      MISTAKE! For GPU it works completely fine, when rows == cols. Otherwise it throws assertion failed.
 * performSORIteration()                ::HOW? Throws segmentation fault CUDA.
 * operator=()                          ::HOW? What is this supposed to enable? Overloading operators?
 * save( String& fileName )                 ::DONE
 * load( String& fileName )                 ::DONE
 * save( File& file)                    ::USED! In save( String& fileName )
 * load( File& file )                   ::USED! In load( String& fileName )
 * print()                                  ::DONE
 * getElementIndex()                    ::TEST? How to test __cuda_callable__? ONLY TEST ON CPU FOR NOW
 */

// GENERAL TODO
/*
 * Template tests for all formats.
 * Figure out __cuda_callable_. When trying to call __cuda_callable__ functions
 *          a segmentation fault (core dumped) is thrown.
 *      ==>__cuda_callable__ works only for CPU at the moment. (for loops vs thread kernel assignment)
 */


#include <TNL/Devices/Host.h>
#include <TNL/Matrices/Matrix.h>
#include <TNL/Matrices/Dense.h>