Skip to content
Snippets Groups Projects
Commit b0d45fd8 authored by Jakub Klinkovský's avatar Jakub Klinkovský
Browse files

Removed obsolete todo notes

parent 9c60deb2
No related branches found
No related tags found
No related merge requests found
......@@ -39,7 +39,6 @@ template< typename MeshConfig,
MeshEntity< MeshConfig, Device, EntityTopology >::
MeshEntity( const MeshEntity< MeshConfig, Device_, EntityTopology >& entity )
// no cross-device copy of subentities and superentities here - Mesh constructor has to rebind pointers
// TODO: check this
: MeshEntityIndex< typename MeshConfig::IdType >( entity )
{
static_assert( ! std::is_same< Device, Device_ >::value, "this should never happen" );
......@@ -70,10 +69,7 @@ operator=( const MeshEntity< MeshConfig, Device_, EntityTopology >& entity )
{
static_assert( ! std::is_same< Device, Device_ >::value, "this should never happen" );
// no cross-device copy here - Mesh::operator= has to rebind pointers
// TODO: check this
// MeshSubentityAccess< MeshConfig, Device, EntityTopology >::operator=( entity );
// MeshSuperentityAccess< MeshConfig, Device, EntityTopology >::operator=( entity );
// no cross-device copy of subentities and superentities here - Mesh::operator= has to rebind pointers
MeshEntityIndex< typename MeshConfig::IdType >::operator=( entity );
return *this;
}
......@@ -211,7 +207,6 @@ template< typename MeshConfig, typename Device >
MeshEntity< MeshConfig, Device, MeshVertexTopology >::
MeshEntity( const MeshEntity< MeshConfig, Device_, MeshVertexTopology >& entity )
// no cross-device copy of superentities here - Mesh constructor has to rebind pointers
// TODO: check this
: MeshEntityIndex< typename MeshConfig::IdType >( entity )
{
static_assert( ! std::is_same< Device, Device_ >::value, "this should never happen" );
......@@ -240,9 +235,7 @@ operator=( const MeshEntity< MeshConfig, Device_, MeshVertexTopology >& entity )
{
static_assert( ! std::is_same< Device, Device_ >::value, "this should never happen" );
// no cross-device copy of subentities and superentities here - Mesh::operator= has to rebind pointers
// TODO: check this
// MeshSuperentityAccess< MeshConfig, Device, EntityTopology >::operator=( entity );
// no cross-device copy of superentities here - Mesh::operator= has to rebind pointers
MeshEntityIndex< typename MeshConfig::IdType >::operator=( entity );
setPoint( entity.getPoint() );
return *this;
......@@ -269,8 +262,7 @@ bool
MeshEntity< MeshConfig, Device, MeshVertexTopology >::
save( File& file ) const
{
if( //! MeshSuperentityStorageLayers< MeshConfig, Device, MeshVertexTopology >::save( file ) ||
! point.save( file ) )
if( ! point.save( file ) )
return false;
return true;
}
......@@ -280,8 +272,7 @@ bool
MeshEntity< MeshConfig, Device, MeshVertexTopology >::
load( File& file )
{
if( //! MeshSuperentityStorageLayers< MeshConfig, Device, MeshVertexTopology >::load( file ) ||
! point.load( file ) )
if( ! point.load( file ) )
return false;
return true;
}
......
......@@ -257,7 +257,6 @@ load( File& file )
std::cerr << "Mesh loading failed." << std::endl;
return false;
}
// TODO: this could be done from the storage layer
// update pointers from entities into the subentity and superentity storage networks
MeshEntityStorageRebinder< Mesh< MeshConfig, Device > >::exec( *this );
return true;
......
......@@ -95,7 +95,6 @@ protected:
MeshSubentityStorageLayer& operator=( const MeshSubentityStorageLayer& other )
{
BaseType::operator=( other );
// TODO: throw exception if allocation fails
storageNetwork.setLike( other.storageNetwork );
storageNetwork = other.storageNetwork;
return *this;
......@@ -105,7 +104,6 @@ protected:
MeshSubentityStorageLayer& operator=( const MeshSubentityStorageLayer< MeshConfig, Device_, EntityTopology, SubdimensionTag >& other )
{
BaseType::operator=( other );
// TODO: throw exception if allocation fails
storageNetwork.setLike( other.storageNetwork );
storageNetwork = other.storageNetwork;
return *this;
......
......@@ -96,7 +96,6 @@ protected:
MeshSuperentityStorageLayer& operator=( const MeshSuperentityStorageLayer& other )
{
BaseType::operator=( other );
// TODO: throw exception if allocation fails
storageNetwork.setLike( other.storageNetwork );
storageNetwork = other.storageNetwork;
return *this;
......@@ -106,7 +105,6 @@ protected:
MeshSuperentityStorageLayer& operator=( const MeshSuperentityStorageLayer< MeshConfig, Device_, EntityTopology, SuperdimensionTag >& other )
{
BaseType::operator=( other );
// TODO: throw exception if allocation fails
storageNetwork.setLike( other.storageNetwork );
storageNetwork = other.storageNetwork;
return *this;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment