- Jan 26, 2022
-
-
Jakub Klinkovský authored
clang-tidy: non-static member functions that can be made static [readability-convert-member-functions-to-static] See https://clang.llvm.org/extra/clang-tidy/checks/readability-convert-member-functions-to-static.html
-
Jakub Klinkovský authored
-
Jakub Klinkovský authored
-
Jakub Klinkovský authored
Discovered by clang-tidy.
-
Jakub Klinkovský authored
clang-tidy: remove unnecessary calls to std::string::c_str(), redundant void arguments and explicit calls to String upon return 1. https://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-string-cstr.html 2. https://clang.llvm.org/extra/clang-tidy/checks/modernize-redundant-void-arg.html 3. https://clang.llvm.org/extra/clang-tidy/checks/modernize-return-braced-init-list.html
-
Jakub Klinkovský authored
- move constructors and assignment operators should be noexcept https://clang.llvm.org/extra/clang-tidy/checks/performance-noexcept-move-constructor.html - avoid unnecessary copy on range loop variables https://clang.llvm.org/extra/clang-tidy/checks/performance-for-range-copy.html - avoid unnecessary value parameters of types that are expensive to copy https://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-value-param.html - avoid unnecessary copy initialization of types that are expensive to copy https://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-copy-initialization.html
-
Jakub Klinkovský authored
The following checks were used: - https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-default-member-init.html - https://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-member-init.html - https://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-string-init.html - https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html
-
Jakub Klinkovský authored
clang-tidy: use '= delete' to prohibit calling of a special member function [modernize-use-equals-delete] See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-delete.html
-
Jakub Klinkovský authored
clang-tidy: dynamic exception specification 'throw()' is deprecated; consider using 'noexcept' instead [modernize-use-noexcept] See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-noexcept.html
-
Jakub Klinkovský authored
Fixed inconsistency between the signatures of the declaration and definition of the vectorProduct method Somehow removing 'const' in the declarations caused a weird lambda-related crash when launching the CUDA kernels in the vectorProduct methods...
-
Jakub Klinkovský authored
-
Jakub Klinkovský authored
clang-tidy: const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls] See https://clang.llvm.org/extra/clang-tidy/checks/readability-avoid-const-params-in-decls.html
-
Jakub Klinkovský authored
-
Jakub Klinkovský authored
-
Jakub Klinkovský authored
Advantages: - pure C++ for client code, no "<<< ... >>>" - hence, clang-format can be used for source code formatting - the HAVE_CUDA guards are not necessary anymore - type of the kernel function can be added to exception messages - easier debugging of kernel launch configurations
-
Jakub Klinkovský authored
-
Jakub Klinkovský authored
...and in a few other places to avoid compiler errors/warnings.
-
Jakub Klinkovský authored
-
- Jan 20, 2022
-
-
Jakub Klinkovský authored
JK/fixes See merge request !121
-
Jakub Klinkovský authored
Does not work, disabled in CMakeLists.txt
-
Jakub Klinkovský authored
-
Jakub Klinkovský authored
-
Jakub Klinkovský authored
-
Jakub Klinkovský authored
-
- Jan 15, 2022
-
-
Jakub Klinkovský authored
Fixed copy-constructor in SparseMatrix See merge request !120
-
Jakub Klinkovský authored
It cannot be default, because the internal view would still point to the original matrix.
-
Jakub Klinkovský authored
-
Jakub Klinkovský authored
-
- Jan 10, 2022
-
-
Jakub Klinkovský authored
Copyright headers for 2022 and forward See merge request !118
-
-
-
The old headers were hard to maintain, inconsistent and contained useless information: - file name (useless, prone to inconsistencies upon renaming) - "description" (useless placeholder that was likely intended to be replaced by the user, not to be used literally) - "begin" date for each file (prone to inconsistencies and copy-paste errors, the information can be found in git) - "copyright" notice (inconsistent years) - "email" (replaced with a project link in the new template) - "Copyright Notice" referring to an obsolete file (tnl/Copyright) that does not exist anymore The new template consists of three simple parts: - copyright notice with updatable years related to the whole project - project name and website URL - SPDX license identifier Note that the SPDX license identifier must be on a line that starts with either "//" or "/*", so we can't use a block comment (/* ... */) for the whole header. But using "//" for block comments is common too.
-
Copyright headers in these files are useless, since they are not distributed on the user's when they install TNL. They were also outdated and inconsistent.
-